CLN: Enforce deprecation of groupby.quantile supporting bool dtype #57744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datapythonista
approved these changes
Mar 6, 2024
Comment on lines
+371
to
+375
| with pytest.raises(TypeError, match=msg): | ||
| method(*args) | ||
| elif dtype is object: | ||
| warn = FutureWarning if groupby_func == "fillna" else None | ||
| warn_msg = "SeriesGroupBy.fillna is deprecated" | ||
| with tm.assert_produces_warning(warn, match=warn_msg): | ||
| result = method(*args) | ||
| with tm.assert_produces_warning(warn, match=warn_msg): | ||
| expected = expected_method(*args) | ||
| result = method(*args) | ||
| expected = expected_method(*args) |
There was a problem hiding this comment.
Those are not related to quantile with bool, right? I'm a bit confused here.
There was a problem hiding this comment.
Yea - this was left over from #57109; the fillna method no longer exists on groupby.
mroeschke
approved these changes
Mar 7, 2024
|
Thanks @rhshadrach |
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Ref: #53975